Fix alignement of chapters with three digit numbering #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Relying on the number of dots in the string seems a little hacky, but it doesn't seem much worse than what we were doing previously. I'm also not familiar with the internals of mdbook at all to give a better suggestion, so this seems okay to me. @steveklabnik @azerupi Have any thoughts? |
Contributor
|
Indeed, it is not ideal but it is better than what we have right now. Maybe we can find a better solution in the future, but let's go with this in the mean time :) Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #242 .
Instead of relying on the length of the chapter number, it now rely on the number of dot(s) it contains.
(i'm not really used to the internals of mdBook, so I may have missed something that would make this patch completely invalid, sorry if is the case!)